Aesthetic, readability and some simplification #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibroheem
commented
Feb 11, 2018
ibroheem
commented
- All uppercase reduced to lowercase.
- Prefer snake_case over camelCase
- Renamed class uuid to basic_uuid, uuid is an alias of basic_uuid
- All other uuid_ classes inherits from basic_uuid
- Addes init_ methods to basic_uuid, instead of calling ctor directly, and then assigning to *this
- ....
Owner
|
It appears that the tests are not updated. Upon adaptation of the test suite also, uuid_balanced() and uuid_strong() call basic_uuid() regardless of what may happen, adding a 40ns overhead to each |
Owner
|
Since I applied most of your modifications by hand on the library myself, I would want you to add your name to the contributors file by yourself and setup another pull request |
Author
|
40 ns? What the heck is that! Let me update the tests and check Edit: that close was a mistake, I wanted to comment only |
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.